Skip to content
Permalink
Browse files
[ DDS ] Fix IsolateManager.initialize() not correctly handling `Senti…
…nel` responses

Fixes flutter/flutter#111926

Change-Id: Iabde854f74410c0eb85f1e4d4ac24f6756395ad1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260220
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Jason Simmons <jsimmons@google.com>
  • Loading branch information
bkonyi authored and Commit Bot committed Sep 20, 2022
1 parent 7f40a29 commit 4eda3397f392ba806fa1e79264767e36a20d26de
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
@@ -1,3 +1,6 @@
# 2.3.1
- Fixed issue where DDS wasn't correctly handling `Sentinel` responses in `IsolateManager.initialize()`.

# 2.3.0
- [DAP] Removed an unused parameter `resumeIfStarting` from `DartDebugAdapter.connectDebugger`.
- [DAP] Fixed some issues where removing breakpoints could fail if an isolate exited during an update or multiple client breakpoints mapped to the same VM breakpoint.
@@ -228,7 +228,7 @@ class IsolateManager {
});
// If the isolate has shutdown after the getVM request, ignore it and
// continue to the next isolate.
if (isolate['kind'] == 'Sentinel') {
if (isolate['type'] == 'Sentinel') {
continue;
}
final name = isolate['name'];
@@ -1,5 +1,5 @@
name: dds
version: 2.3.0
version: 2.3.1
description: >-
A library used to spawn the Dart Developer Service, used to communicate with
a Dart VM Service instance.

0 comments on commit 4eda339

Please sign in to comment.