Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] progress bar & format & bitrate selection #148

Closed
reyerdam opened this issue Jan 7, 2018 · 3 comments
Closed

[Improvement] progress bar & format & bitrate selection #148

reyerdam opened this issue Jan 7, 2018 · 3 comments

Comments

@reyerdam
Copy link

reyerdam commented Jan 7, 2018

Ideas:

  • add a Progress Bar for the converting/Download process.
  • input option to select in which format & which bitrate the video should be converted.
@Rudloff
Copy link
Owner

Rudloff commented Jan 7, 2018

  • We can't really add a progress bar since the download is managed directly by the browser. It would require managing the download in JavaScript but this causes horrible performances for big files.
    Ideally, the browser should display a progress bar in its download manager but this requires knowing the file size and we have no way to predict the converted file size.
  • We can totally add this. Do you have specific formats in mind?
@reyerdam
Copy link
Author

reyerdam commented Jan 7, 2018

We can totally add this. Do you have specific formats in mind?

  • i think about mp3, mp4, flv, wav
  • custom bitrates which i think are standard on most yt converters:
320 kbps
256 kbps
192 kbps
128 kbps
96 kbps
64 kbps
Rudloff added a commit that referenced this issue Jan 24, 2018
It allows user to convert videos to several other audio/video formats

Fixes #148
Rudloff added a commit that referenced this issue Jan 24, 2018
It allows user to convert videos to several other audio/video formats

Fixes #148
@Rudloff
Copy link
Owner

Rudloff commented Jan 24, 2018

This has been added to the develop branch.
You can enable it by adding this to your config/config.yml file:

convertAdvanced: true
convertAdvancedFormats: [mp3, avi, flv, wav]

It will add new options on the download page that allow you to convert the video
image

@Rudloff Rudloff closed this as completed Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants